nifti2_data_format
nifti2_data_format > Proposal: nifticlib - remove nx,ny,..dx,...
Mar 1, 2011 03:03 PM | Cinly Ooi
Proposal: nifticlib - remove nx,ny,..dx,...
Dear All,
I am not sure how much reworking of nifticlib is planned. I hope not much. But if you are thinking about big rework can I suggest not having duplicate-looking variables storing the same information?
My problem here is nx,ny,nz... and dx, dy, dz ... is effectively a duplication of dim[1..] and pixdim[1.]. As programmers we are more used to using dim[] and pixdim[] instead of nX and dX. Having both nX/dX and dim[]/pixdim[] causes confusion, as C cannot easily keep them in sync. Eliminating nX and dX will remove this confusion. It took me quite a lot of debugging to work out that nX has priority overe dim[] in nifticlib and that setting dim[] in nifti_image has no effect when writing image file using nifti_image_write because it will be overwritten by nX and I am not alone in this.
However, I recognize that nifticlib itself, and a lot of other programs might actually uses nX and dX and therefore, it is not an easy decision to make to retires nX/dX.
Thanks
Cinly
I am not sure how much reworking of nifticlib is planned. I hope not much. But if you are thinking about big rework can I suggest not having duplicate-looking variables storing the same information?
My problem here is nx,ny,nz... and dx, dy, dz ... is effectively a duplication of dim[1..] and pixdim[1.]. As programmers we are more used to using dim[] and pixdim[] instead of nX and dX. Having both nX/dX and dim[]/pixdim[] causes confusion, as C cannot easily keep them in sync. Eliminating nX and dX will remove this confusion. It took me quite a lot of debugging to work out that nX has priority overe dim[] in nifticlib and that setting dim[] in nifti_image has no effect when writing image file using nifti_image_write because it will be overwritten by nX and I am not alone in this.
However, I recognize that nifticlib itself, and a lot of other programs might actually uses nX and dX and therefore, it is not an easy decision to make to retires nX/dX.
Thanks
Cinly
Threaded View
| Title | Author | Date |
|---|---|---|
| Mark Jenkinson | Feb 28, 2011 | |
| Mark Jenkinson | Mar 15, 2011 | |
| Cinly Ooi | Mar 15, 2011 | |
| Cinly Ooi | Mar 2, 2011 | |
| Ged Ridgway | Mar 7, 2011 | |
| Jon Clayden | Mar 5, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Andrew Janke | Mar 1, 2011 | |
| Cinly Ooi | Mar 2, 2011 | |
| Satrajit Ghosh | Mar 5, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Denis Rivière | Feb 28, 2011 | |
| Cinly Ooi | Mar 1, 2011 | |
| Brandon Whitcher | Mar 1, 2011 | |
| Satrajit Ghosh | Feb 28, 2011 | |
| Jonas Larsson | Mar 1, 2011 | |
| Mark Horsfield | Mar 1, 2011 | |
| Andrew Janke | Mar 1, 2011 | |
| Jochen Weber | Feb 28, 2011 | |
| Randall Frank | Mar 1, 2011 | |
| Michael Martinez | Feb 28, 2011 | |
| Cinly Ooi | Feb 28, 2011 | |
| Chris Rorden | Feb 28, 2011 | |
